Quality Standards Skill

Context (Input)

• Need to understand protected quality thresholds
• Running comprehensive quality checks before commit
• Determining which specialized skill to use for specific issues
• Quick reference for quality tool commands

Task (Function)

Understand quality metrics and route to appropriate specialized skill for fixes.

Success Criteria: Know which skill to use for your specific quality issue.

Protected Quality Thresholds

CRITICAL: These thresholds are protected and must NEVER be lowered.

PHPInsights (Source Code)

PHPInsights (Tests)

Other Tools

Quick Reference Commands

Comprehensive Checks

# Run all CI checks (recommended before commit)
make ci

Success: Must output "✅ CI checks successfully passed!"

Individual Quality Checks

Testing Commands

Routing to Specialized Skills

When quality checks fail, use the appropriate specialized skill:

Architecture Issues

• Deptrac violations → [deptrac-fixer](../deptrac-fixer/SKILL.md)

- Domain depends on Infrastructure - Layer boundary violations - "must not depend on" errors

• DDD architecture patterns → [implementing-ddd-architecture](../implementing-ddd-architecture/SKILL.md)

- Creating new entities/value objects - Implementing CQRS patterns - Understanding layer responsibilities

Code Quality Issues

• High cyclomatic complexity → [complexity-management](../complexity-management/SKILL.md)

- PHPInsights complexity < 94% - PHPMD reports high CCN - Methods too complex

• Structural/naming issues → [code-organization](../code-organization/SKILL.md)

- Class in wrong directory for its type - Vague variable or class names - Hardcoded config values that should be in .env - Namespace doesn't match directory structure

• Code style issues → Run make phpcsfixer

- PSR-12 violations - Line length > 100 chars - Formatting issues

Testing Issues

• Test failures → [testing-workflow](../testing-workflow/SKILL.md)

- Unit/Integration/E2E failures - Mutation testing (Infection) - Test coverage < 100%

Workflow Integration

• Before committing → [ci-workflow](../ci-workflow/SKILL.md)

- Run all checks systematically - Fix failures in priority order - Ensure all checks pass

• PR review feedback → [code-review](../code-review/SKILL.md)

- Fetch and address PR comments - Systematic comment resolution

Quality Improvement Workflow

Step 1: Run Comprehensive Checks

make ci

Step 2: Identify Failing Check

Check output for specific failure:

❌ CI checks failed:
  - phpinsights: Complexity score too low (93.5% < 94%)

Step 3: Use Specialized Skill

Based on failure type, use appropriate skill:

Step 4: Re-run CI

make ci

Repeat until: "✅ CI checks successfully passed!"

Constraints (Parameters)

NEVER

• Lower quality thresholds in config files (phpinsights.php, infection.json5, etc.)
• Skip failing checks to "save time"
• Commit code without all CI checks passing
• Modify deptrac.yaml to allow violations (fix code, not config)
• Disable security checks
• Add suppression/ignore annotations to hide quality issues (@SuppressWarnings, @infection-ignore, @codeCoverageIgnore, @psalm-suppress, @phpstan-ignore, phpcs:ignore, @phpinsights-ignore)

ALWAYS

• Fix code to meet standards (not config to meet code)
• Run make ci before creating commits
• Use specialized skills for specific quality issues
• Maintain 100% test coverage
• Keep cyclomatic complexity low (target: < 5 per method)
• Respect hexagonal architecture boundaries

Format (Output)

Expected CI Output

✅ CI checks successfully passed!

Expected PHPInsights Output

[CODE] 100.0 pts       ✅ Target: 100%
[COMPLEXITY] 94.0 pts  ✅ Target: 94%
[ARCHITECTURE] 100 pts ✅ Target: 100%
[STYLE] 100.0 pts      ✅ Target: 100%

Expected Deptrac Output

✅ No violations found

Expected Infection Output

Mutation Score Indicator (MSI): 100%

Verification Checklist

After using this skill:

• Identified which quality check is failing
• Selected appropriate specialized skill for the issue
• Ready to execute specialized skill workflow
• Understand which threshold applies to the failure
• Know the command to re-run the check after fixes

Related Skills

• [ci-workflow](../ci-workflow/SKILL.md) - Run comprehensive CI validation
• [complexity-management](../complexity-management/SKILL.md) - Reduce complexity, improve quality
• [code-organization](../code-organization/SKILL.md) - Fix structural/naming issues, extract hardcoded configs
• [deptrac-fixer](../deptrac-fixer/SKILL.md) - Fix architectural violations
• [implementing-ddd-architecture](../implementing-ddd-architecture/SKILL.md) - Understand DDD patterns
• [testing-workflow](../testing-workflow/SKILL.md) - Fix test failures, improve coverage

Reference Documentation

For detailed examples and patterns, see:

• Refactoring patterns → complexity-management skill
• Architecture rules → implementing-ddd-architecture skill
• Layer boundaries → deptrac-fixer skill
• Testing strategies → testing-workflow skill